https://bugs.kde.org/show_bug.cgi?id=374097

Sven Brauch <m...@svenbrauch.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/kde
                   |                            |v-python/600f6b34d95e506fdf
                   |                            |941c5bfadc79aeaf7de617
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #19 from Sven Brauch <m...@svenbrauch.de> ---
Git commit 600f6b34d95e506fdf941c5bfadc79aeaf7de617 by Sven Brauch.
Committed on 14/01/2017 at 12:19.
Pushed by brauch into branch '5.1'.

completion: wrap expression visitor into a read lock

Unlike in the parse job, we do not hold the parse lock for the context
which is passed to the expression visitor. Thus, it might be modified
or deleted by a parse job while we're passing the pointer around. This
means that after data is taken out of the DUContextPointer, the read
lock must not be released again while the object is in use.

Likely the reason for occasional crashes in completion in some situations.

M  +8    -7    codecompletion/context.cpp
M  +3    -0    duchain/declarationbuilder.cpp
M  +3    -5    duchain/expressionvisitor.cpp

https://commits.kde.org/kdev-python/600f6b34d95e506fdf941c5bfadc79aeaf7de617

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to