https://bugs.kde.org/show_bug.cgi?id=509634

Mark Wielaard <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #2 from Mark Wielaard <[email protected]> ---
NEWS entry OK.
All linux handlers for quotactl and quotactl_fd added a POST handler.
- Question, why isn't quotactl wrapped on ppc32?
  Probably just an oversight, ppc64 was wrapped in commit 7f74ba249
Typo funtion_name -> function_name argument corrected in
common_[pre|post]_io_getevents. OK
Added common_[pre|post]_quotactl_p4_check called from PRE/POST quotactl[_fd]
wrappers. OK
- common_pre_quotactl_p4_check should not SET_STATUS_Failure( VKI_EINVAL ) on
unknown subop, maybe the kernel does know, if not the kernel will set it (maybe
warn? if not quiet?)
vki-linux.h added macros to get subcommand, subcommand ids and structs used.
OK.

Looks good, but would like to see ppc32 wrapped and SET_STATUS_Failure removed
from common_pre_quotactl_p4_check.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to