https://bugs.kde.org/show_bug.cgi?id=510760
Robert <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from Robert <[email protected]> --- Currently, Digikam's `../core/cmake/modules/FindEigen3.cmake` has a macro defined ( `_eigen3_check_version` ) which rely on being able to find the following defines: ``` #define EIGEN_WORLD_VERSION 3 #define EIGEN_MAJOR_VERSION 4 #define EIGEN_MINOR_VERSION 1 ``` by looking for them in a file from Eigen project called `../core/cmake/modules/FindEigen3.cmake`. This used to work for Eigen versions up to and including version 3.4.1. Starting with version 5 the Eigen project did the sensible thing and adopted semantic versioning, while at same time moving the definitions to a different file `Eigen/Version`: ``` #ifndef EIGEN_VERSION_H #define EIGEN_VERSION_H // The "WORLD" version will forever remain "3" for the "Eigen3" library. #define EIGEN_WORLD_VERSION 3 // As of Eigen3 5.0.0, we have moved to Semantic Versioning (semver.org). #define EIGEN_MAJOR_VERSION 5 #define EIGEN_MINOR_VERSION 0 #define EIGEN_PATCH_VERSION 1 #define EIGEN_PRERELEASE_VERSION "dev" #define EIGEN_BUILD_VERSION "master" #define EIGEN_VERSION_STRING "5.0.1-dev+master" #endif // EIGEN_VERSION_H ``` The cmake find module should be amended to parse the definitions from the new file (and possibly as a fallback from the previous file). -- You are receiving this mail because: You are watching all bug changes.
