https://bugs.kde.org/show_bug.cgi?id=513257

--- Comment #4 from [email protected] ---
(In reply to Mark Wielaard from comment #3)
> +POST(sys_lsm_list_modules)
> +{
> +   POST_MEM_WRITE((Addr)ARG2, sizeof(__vki_u32));
> +   POST_MEM_WRITE(ARG1, *(__vki_u32 *)ARG2);
> +}
> 
> The first POST_MEM_WRITE is correct, the kernel will write out the actual
> size used. But also redundant because the value is (should) already (be)
> defined when going into the syscall. The value might change, but whether or
> not it is defined doesn't.

Just to make sure I'm getting this right:  Does the above mean that for
memcheck's ARG2 memory bookkeeping purposes, the
PRE_MEM_READ("lsm_list_modules(size)", ARG2, sizeof(__vki_u32)); is sufficient,
and for that exact reason POST_MEM_WRITE((Addr)ARG2, sizeof(__vki_u32)); can be
dropped?  Doesn't memcheck need to track memory reads separately from memory
writes?

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to