https://bugs.kde.org/show_bug.cgi?id=506959

cwo <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/mult
                   |                            |imedia/elisa/-/commit/fa944
                   |                            |186bc3f4e625d4e75350071c698
                   |                            |28587e45
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from cwo <[email protected]> ---
Git commit fa944186bc3f4e625d4e75350071c69828587e45 by Christoph Wolk.
Committed on 06/01/2026 at 16:55.
Pushed by cwo into branch 'master'.

qml/HeaderBar: only replace image if it's loaded

Elisa sometimes fails to load the HeaderBar background on intial load,
instead yielding a simple dark or light background according to the
color scheme default. On dark themes, this is visually unpleasant, on
light themes it is unpleasant and can lead to essentially unreadable
light-on-light text. Playing another song with a different image will
fix it. The problem is that Elisa considers the image file loaded as
soon as its status changes (or more precisely, the status change signal
is sent). In particular during initial startup, it often seems to happen
that the status is still Loading when the signal is sent, and trying to
replace it onto the stackview will just silently fail.

Instead, we test if the image is actually loaded, and only process it
further if it is. If the image fails to load, it'll be replaced by the
fallback image, which is still better than the empty one. (And should
that fail too it's a broken installation so some glitches are to be
expected, and the incubator object will be taken care of when the next
image is loaded)

M  +1    -1    src/qml/HeaderBar.qml

https://invent.kde.org/multimedia/elisa/-/commit/fa944186bc3f4e625d4e75350071c69828587e45

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to