https://bugs.kde.org/show_bug.cgi?id=512273

cwo <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
                   |ma/plasma-desktop/-/commit/ |ma/plasma-desktop/-/commit/
                   |e1ea4301726335e2ebe9e40a2f1 |d610bfd7b1a47a0f6993d2a0c34
                   |a589790f0b26f               |199e079942fbc

--- Comment #12 from cwo <[email protected]> ---
Git commit d610bfd7b1a47a0f6993d2a0c34199e079942fbc by Christoph Wolk.
Committed on 18/01/2026 at 14:09.
Pushed by cwo into branch 'Plasma/6.6'.

desktoppackage/applet: don't make applet huge when changing location

CompactApplet increases the minimum size of the fullRepresentation a
"little" to leave room for a separator line of one pixel between the
widget contents and panel. The extra height is bound to 0 if vertical,
and to the separator's height if horizontal. The separator's height in
turn is set to 1 in the separator's states for top/bottom panels. (Extra
width works the same way.) But of course, if the panel changes location,
these changes all have to happen individually, and the order of handlers
is arbitrary. So if the binding is updated before the state
PropertyChanges happen, we add the separator's (previous) width to the
minimumHeight, which corresponds to the popup's width, and for typical
applets may be hundreds of pixels instead of one. This in turn will
cause the PopupWindow to resize to conform to the new minimum
requirements. Then, the separator is adjusted to the new value and is a
line again, but now the window is permanently large (or at least until
the user manually resizes it).

Instead, we drop the binding completely, and set the extraSize values
explicitly as part of the separator's PropertyChanges. This way we can
have a consistent order in which the updates happen, and as we now set
explicit values (of 0 or 1) they can't be larger than that anyway.
FIXED-IN: 6.6.0


(cherry picked from commit e1ea4301726335e2ebe9e40a2f1a589790f0b26f)

Co-authored-by: Christoph Wolk <[email protected]>

M  +10   -2    desktoppackage/contents/applet/CompactApplet.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/d610bfd7b1a47a0f6993d2a0c34199e079942fbc

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to