https://bugs.kde.org/show_bug.cgi?id=514613

Mark Wielaard <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #8 from Mark Wielaard <[email protected]> ---
We need more/better tests.
This fixes the testcase in the description where there are zero reachable
bytes, but it causes a double closing tag when there are reachable bytes. e.g.

#include <stdlib.h>

static void *p;

int main ()
{
  p = malloc (1024);
  return 0;
}

That is because the code did contain a closing tag, but the condition to show
it was wrong:

      if (VG_(clo_xml) && MC_(bytes_reachable)) {
         umsg_or_xml("  </still_reachable>\n");
      }

The idea is that after <still_reachable> it could show some
<reachable_heuristic> blocks.
Only after does the still_reachable tag gets closed, but it should have been
closed always, not just when bytes_reachable != 0.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to