https://bugs.kde.org/show_bug.cgi?id=515183

Mark Wielaard <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #10 from Mark Wielaard <[email protected]> ---
I agree with this change.
But note that drd/tests/std_thread2.vgtest contains vgopts --num-callers=1
So this testcase fails now.

+valgrind: Bad option: --num-callers=1
+valgrind: '--num-callers' argument must be between 2 and 500
+valgrind: Use --help for more information or consult the user manual.

Probably easy to fix by using --num-callers=2 and adjusting the backtrace in
the .exp

diff --git a/drd/tests/std_thread2.stderr.exp
b/drd/tests/std_thread2.stderr.exp
index 818b5cf57902..ec6cf60f5ad0 100644
--- a/drd/tests/std_thread2.stderr.exp
+++ b/drd/tests/std_thread2.stderr.exp
@@ -2,6 +2,7 @@
 Thread 2:
 Conflicting store by thread 2 at 0x........ size 4
    at 0x........: main::LAMBDA::operator()() const (std_thread2.cpp:21)
+   by 0x........: void std::__invoke_impl<void,
main::LAMBDA>(std::__invoke_other, main::{lambda()#1}&&) (invoke.h:?)
 Allocation context: BSS section of std_thread2

 Done.
diff --git a/drd/tests/std_thread2.vgtest b/drd/tests/std_thread2.vgtest
index 74917b289d49..785eadebc204 100644
--- a/drd/tests/std_thread2.vgtest
+++ b/drd/tests/std_thread2.vgtest
@@ -1,4 +1,4 @@
 prereq: test -e std_thread2 && ./supported_libpthread
-vgopts: --check-stack-var=yes --show-confl-seg=no --num-callers=1
--default-suppressions=no --suppressions=std_thread2.supp
+vgopts: --check-stack-var=yes --show-confl-seg=no --num-callers=2
--default-suppressions=no --suppressions=std_thread2.supp
 prog: std_thread2
 stderr_filter: filter_lambda

But given the source location in the .h file and the mangling might need
testing with different compiler versions first and maybe an additional filter.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to