https://bugs.kde.org/show_bug.cgi?id=478793

Finley Watson <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://invent.kde.org/sdk/
                   |                            |lokalize/-/commit/9db4b711f
                   |                            |a39dd1beaedd932dea30cd16f88
                   |                            |ea50

--- Comment #5 from Finley Watson <[email protected]> ---
Git commit 9db4b711fa39dd1beaedd932dea30cd16f88ea50 by Finley Watson, on behalf
of Jaimukund Bhan.
Committed on 07/02/2026 at 15:53.
Pushed by finw into branch 'master'.

Glossary - Create and save new glossary file

Lokalize could not save the new glossary file, failed to add new entries to
glossary and crashed whenever the search field was typed into, because the file
was not opened inside `Glossary::load()` if it was newly created. This MR adds
the code to open the file, allowing entries into the glossary and stops the app
from crashing whenever the user types inside the search field.

This MR also adds the function `Glossary::ensureFileExists()` to ensure the
glossary file path is valid by showing a warning popup stating the reason of
path invalidity and opens the **Project Configuration** window for the user to
enter a valid path, pre-filled with a default valid path. This check is needed
to alert users that their glossary files cannot be created.

In this MR, `Project::save()` calls `Glossary::save()`, which calls
`Glossary::ensureFileExists()`. The project save function is run when the user
makes a change through the **Project Configuration** window (also shown at
creation of a new project). If the user enters an invalid path and tries to set
it by clicking **Apply** or **Ok**, the newly created function prompts the user
to either use the default path or enter a valid path.

Task: sdk/lokalize#24
Related: bug 513766

M  +53   -5    src/glossary/glossary.cpp
M  +4    -0    src/glossary/glossary.h
M  +2    -0    src/project/project.cpp

https://invent.kde.org/sdk/lokalize/-/commit/9db4b711fa39dd1beaedd932dea30cd16f88ea50

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to