https://bugs.kde.org/show_bug.cgi?id=512332

Nate Graham <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|                            |6.6.0
  Fixed/Implemented|                            |
                 In|                            |
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-workspace/-/commi
                   |                            |t/23bd030b2051b4d5d5a74ad23
                   |                            |e3487fcde26e443
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Nate Graham <[email protected]> ---
Git commit 23bd030b2051b4d5d5a74ad23e3487fcde26e443 by Nate Graham, on behalf
of Alexey Rochev.
Committed on 09/02/2026 at 15:00.
Pushed by ngraham into branch 'master'.

KAStatsFavoritesModel: retrieve launched entry by normalized id from m_items
list


The problem with m_itemEntries map is that entries are stored there several
times
with different keys: normalized id, url and path.

When desktop entry is overriden in user directory, and ksycoca is updated,
entry
is reloaded but is still stored in m_itemEntries with the old keys.

This is not a problem for normalized id, but url and path keys will become
incorrect in this case.

Then in trigger() we will get a url of entry found via its normalized id (which
didn't change) and try to find it again using that url. Which doesn't work
because entry->url() returns new url for overridden desktop entry, but
m_itemEntries contains key with the old url.

This change sidesteps this issue by always operating on an entry found via
normalized id, which is simpler and more efficient anyway.
FIXED-IN: 6.6.0

M  +1    -12   applets/kicker/kastatsfavoritesmodel.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/23bd030b2051b4d5d5a74ad23e3487fcde26e443

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to