https://bugs.kde.org/show_bug.cgi?id=506567

--- Comment #27 from Caballo Juan <[email protected]> ---
(In reply to David Edmundson from comment #26)
> That last patch is quite similar to
> https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/292/diffs  

Yeah, it's quite similar as the problem is pretty much in the authenticate()
logic. The cancelEmitFailed (which I removed in the latest diff I posted a few
comments above) was trying to deal with some weird race condition where an
authentication failure was triggered without doing anything before/after
suspend

Fushan introduced a couple changes some few months ago to deal with this
specific problem (it is, however, causing constant authentication failures
before/after suspend, at least for me). Point is, I removed that specific
cancelEmitFailed stuff because it's completely unrelated to the actual
fingerprint issue.

The only thing that probably needs more polishing is the part where I simply
ignore the existing timer and call authenticate() again after 1ms. right now it
works just fine, but I noticed the timer was being set to some ~2.5s. I assume
the auth UI is supposed to be disabled for that duration but ehhhh I wanted a
quick solution and 1ms just cuts it. 

BTW, since I can't edit my own messages, I can't fix a small error in the diff
I sent. It should be `if (info.contains(QStringLiteral("finger on the
fingerprint reader")) || info.contains(QStringLiteral("timed out"))`.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to