https://bugs.kde.org/show_bug.cgi?id=465716
mctvvtcm <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from mctvvtcm <[email protected]> --- (In reply to Jack Hill from comment #3) > Git commit f8602efd275fe6a5ef61569e4cc36043fe4dafad by Jack Hill, on behalf > of Gary Wang. > Committed on 22/10/2024 at 19:08. > Pushed by jackh into branch 'master'. > > Lyrics: load sidecar .lrc file as song lyrics > > It's common to have lyrics in a sidecar file (`.lrc`). Currently Elisa only > loads lyrics lived in the ID3 tag and ignores the sidecar file. > > This commit adds support for reading from lrc files, but disables the > ability to modify the lyrics of an lrc file. TrackDataType now stores the > location of the lyrics file, which should make it easy to implement this in > the future. > > Tested manually: > > 1. Create an audio file called `sample_track.mp3` and a valid lyrics file > `sample_track.lrc` in the same directory > 2. Use Elisa to play `sample_track.mp3` > 3. Open the Now Playing view > 4. Open the file metadata dialog > > The lyrics are visible in the metadata dialog and Now Playing view. The > lyrics are also correctly synchronized. > > M +1 -1 src/datatypes.h > M +14 -1 src/filewriter.cpp > M +3 -1 src/models/editabletrackmetadatamodel.cpp > M +39 -17 src/models/trackmetadatamodel.cpp > M +3 -2 src/models/trackmetadatamodel.h > > https://invent.kde.org/multimedia/elisa/-/commit/ > f8602efd275fe6a5ef61569e4cc36043fe4dafad -- You are receiving this mail because: You are watching all bug changes.
