https://bugs.kde.org/show_bug.cgi?id=295974

[email protected] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #10 from [email protected] ---
Hello Sasshka,

the attached patch makes sense to me.  Comparing patched and unpatched sources,
I see in both cases:  

$ tests/vg_regtest none/tests/amd64/sse4-64.vgtest
none/tests/x86/sse4-x86.vgtest
sse4-64:         valgrind   -q ./sse4-64 
sse4-x86:        valgrind   -q ./sse4-x86 

== 2 tests, 0 stderr failures, 0 stdout failures, 0 stderrB failures, 0 stdoutB
failures, 0 post failures ==

Which is expected.  Looking closer, the patched binary shows the expected logs
(while the unpatched doesn't):

$ ../../../vg-in-place ./sse4-x86 |& fgrep pextrd
r     pextrd $0 60b160857d45c48447b8d8c0eeef1e50 5555555555555555
00000000eeef1e50
m     pextrd $0 60b160857d45c48447b8d8c0eeef1e50 5555555555555555
55555555eeef1e50
r     pextrd $1 60b160857d45c48447b8d8c0eeef1e50 5555555555555555
0000000047b8d8c0
m     pextrd $1 60b160857d45c48447b8d8c0eeef1e50 5555555555555555
5555555547b8d8c0
r     pextrd $2 60b160857d45c48447b8d8c0eeef1e50 5555555555555555
000000007d45c484
m     pextrd $2 60b160857d45c48447b8d8c0eeef1e50 5555555555555555
555555557d45c484
r     pextrd $3 60b160857d45c48447b8d8c0eeef1e50 5555555555555555
0000000060b16085
m     pextrd $3 60b160857d45c48447b8d8c0eeef1e50 5555555555555555
5555555560b16085
$ 

Nice.  No regression spotted.  The only nitpick I can find is a typo in your
NEWS entry:

$ git diff
diff --git a/NEWS b/NEWS
index 0f28fcb87..2e517b62c 100644
--- a/NEWS
+++ b/NEWS
@@ -28,7 +28,7 @@ are not entered into bugzilla tend to get forgotten about or
ignored.
 519574  valgrind 3.27 "--fair-sched=yes" does not work
 519613  Valgrind incorrectly unpacks the result of sys_port (port_getn)
         on error, leading to a ~60s wallclock time delay on every call
-295974  Add SSE4.1 PEXTRD instructions for x86 32 bit
+295974  Add SSE4.1 PEXTRD instruction for x86 32 bit

 To see details of a given bug, visit
   https://bugs.kde.org/show_bug.cgi?id=XXXXXX
$

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to