https://bugs.kde.org/show_bug.cgi?id=450857

--- Comment #6 from [email protected] ---
Created attachment 192205
  --> https://bugs.kde.org/attachment.cgi?id=192205&action=edit
Video showing global locked selection masks being deleted

Maybe a video would help? Perhaps what I'm seeing is not 100% the same as what
was originally reported, but it still seems wrong to me.

When you have a local selection mask attached to a paint layer, you can lock it
and then select, deselect, do whatever, and it behaves as expected. But if you
copy that selection mask to the root layer and make it a global selection mask,
then suddenly deselecting it with Ctrl-D just deletes the entire layer, whether
it's locked or not.

My uneducated guess is that it's happening in the code somewhere here?
https://invent.kde.org/graphics/krita/-/blob/master/libs/image/commands/kis_deselect_global_selection_command.cpp?ref_type=heads#L35
Either this code needs to be updated to simply check if the returned selection
mask is locked before deleting, or else the call to
image->rootLayer()->selectionMask() needs to be handle the possibility that
there may be multiple selection masks attached to the root layer.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to