https://bugs.kde.org/show_bug.cgi?id=519356

Freya Lupen <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #2 from Freya Lupen <[email protected]> ---
The reason is it's connected to the triggered() signal rather than toggled(),
in kis_paintop_box.cc (@518).

If I remember correctly, it was to avoid potential recursion.
m_eraserTogglePresetAction is connected to slotInputDeviceChanged(), which
syncs the action's checked state to whether the input device is an eraser.
triggered() only activates if the user triggered the action, not the code, but
toggled() activates any time the check state changes, including from code. So
if toggled() was connected to slotInputDeviceChanged(), it would cause an
infinite loop; except not really, because if the check state is the same as
before, toggled() will just do nothing.

Still, it might get called twice when flipping to the eraser end of a stylus.
That's probably not a big deal, and probably could be rewritten to avoid that
anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to