https://bugs.kde.org/show_bug.cgi?id=338365
Paul Floyd <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #7 from Paul Floyd <[email protected]> --- This looks useful. A few things need changing though. 1. 0x1003 for the client request is now in use. It needs to be changed to the last free value. 2. The valgrind.h.in comment and the xml doc mixes up hex and decimal. It was correct back when the patch was created and the Valgrind version was 3.9 (since 0x309 looks like 309). Since Valgrind 3.10 that no longer works. (__VALGRIND_MAJOR__ << 8) | (__VALGRIND_MINOR__) now gives (3 << 8 | 28) which is 0x31c. That should all stick to decimal and use __VALGRIND_MAJOR__*100 + __VALGRIND_MINOR__. -- You are receiving this mail because: You are watching all bug changes.
