https://bugs.kde.org/show_bug.cgi?id=338365
Mark Wielaard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Ever confirmed|0 |1 Status|REPORTED |CONFIRMED --- Comment #10 from Mark Wielaard <[email protected]> --- (In reply to jgfloyd229 from comment #8) > Created attachment 192716 [details] > updated patch > > fixed merge conflicts > switched from hex to decimal > added test > updated the doc This looks good. But please add a bit more in the commit message about what precisely is added. And also add credit to the Étienne Dupuis for the original idea/patch. Also I would extend the testcase a little. Check the version is < 2000 (assuming we never reach valgrind version 20). And a (post) run to check it really return zero as Version. -- You are receiving this mail because: You are watching all bug changes.
