[kwin] [Bug 519481] Disabled desktop effect plugins for "Transluency" and "Wobbly Windows" will somtimes get enabled again

[David W.]

https://bugs.kde.org/show_bug.cgi?id=519481

--- Comment #17 from David W. <protec...@outlook.com> ---
Second try:

We have this code, and I think the bug might be here:

        const bool restoreToDefault = effect.enabledByDefaultFunction
            ? effect.status == Status::EnabledUndeterminded
            : shouldEnable == effect.enabledByDefault;
        if (restoreToDefault) {
            kwinConfig.deleteEntry(key, KConfig::Notify);
        } else {
            kwinConfig.writeEntry(key, shouldEnable, KConfig::Notify);
        }

For plugins, this evaluates to shouldEnable == effect.enabledByDefault, but in
loadPluginEffects():
 effect.enabledByDefault = pluginEffect.isEnabledByDefault();
This means that only the metadata setting is checked (for WooblyWindows, it is
"false"). The kwinConfig setting (which is "true" in Kubuntu) is not checked
here, so its value is lost.

-- 
You are receiving this mail because:
You are watching all bug changes.