https://bugs.kde.org/show_bug.cgi?id=520894
cwo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-workspace/-/commi |ma/plasma-workspace/-/commi |t/5b3da59c060167d4a354f7686 |t/93106aeea1df992eb8971b7b5 |15ff630026d15d9 |affc2e073b879a7 --- Comment #12 from cwo <[email protected]> --- Git commit 93106aeea1df992eb8971b7b5affc2e073b879a7 by Christoph Wolk. Committed on 10/06/2026 at 22:29. Pushed by cwo into branch 'Plasma/6.7'. applets/kicker: sometimes use normalizedId when unfavoriting Kicker backend uses the normalized id when favoriting things, and the unnormalized id when unfavoriting them. This is because the normalized id may no longer work, for example if a folder is favorited and then deleted (see bug 474120). This however, breaks on malformed desktop file names with a capital letter and colon, such as "Test: 1.desktop". We do a QString -> QUrl -> QString round trip, "Test:" is interpreted as an url scheme, and while this is maintained, it is (correctly) case-folded as the schemes are case-insensitive and their canonical form is lower case. When such a desktop file is favorited, it is correctly added (as the normalized id already contains the "applications:" url scheme, and so the "Test:" part is not interpreted as one, but can't be removed anymore as it will try to remove "test: 1.desktop" instead, which is not a favorite. Instead, use the normalizedId in case [a] the post-round trip string only differs in case from the unnormalized id (where the scheme bug can happen) [b] we're not dealing with a local file (where the post-deletion bug can happen) and [c] we don't already have an "applications:" scheme (for good measure). This should handle both the malformed name and post-deletion file case, and hopefully not affect any other schemes, which I think should end up with the same id and normalized id anyway. (cherry picked from commit 5b3da59c060167d4a354f768615ff630026d15d9) Co-authored-by: Christoph Wolk <[email protected]> M +17 -0 applets/kicker/kastatsfavoritesmodel.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/93106aeea1df992eb8971b7b5affc2e073b879a7 -- You are receiving this mail because: You are watching all bug changes.
