https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #16 from Aleksandar Rikalo <aleksandar.rik...@imgtec.com> --- Thank You for review. I agree with changes in comment and also You are right about name. I vote for ASSUME_ALIGNED, in that case, it is clear that there is a assumption. (In reply to Ivo Raisr from comment #15) > I am quite happy with the first patch (1/4). > That particular expression in vki-linux.h has been extensively studied and > found to be benign with regards to potential misaligned access. > > I'd reword the comment for PTR_CAST slightly: > // Some architectures (eg. mips, arm) do not support unaligned memory access > // by hardware, so GCC warn about suspicious situations. This macro could > // be used to avoid these warnings but only after careful examination. > > Also why did you chose name 'PTR_CAST'? Perhaps ALIGN_CAST or ASSUME_ALIGNED > would be more self explanatory? -- You are receiving this mail because: You are watching all bug changes.
