https://bugs.kde.org/show_bug.cgi?id=523592
--- Comment #1 from Friedrich W. H. Kossebau <[email protected]> --- Hi, thanks for the report and finding the error & proposing a fix. Right now only quickly looked at the code, but seems like the correct one indeed. Embarrassing for me. Too bad this macro never got proper unit tests, only relied on indirect usage by all the existing deployments where this argument though seems to have slipped unused. Two questions: a) Are you fine with being referenced in the commit message by "Fix by [email protected]", or would you prefer some other reference? b) The code you quoted for 5.115.0, where did you get it from? As it seems to not match the tagged version in the ECM repo, it also never was changed since the line was first added, being as you quoted it for 6.28.0? Fear the fix will only land in a released 6.* version (should still make it for 6.29), the 5.* series would only ever see another release if there was a very critical bug. Would still add the fix to the branch though, for completeness. So if you are stuck with 5.115, I hope you find a solution by either using a local copy or getting the distributor to include that fix. Planning to look close at the patch tonight CEST, and ideally should also land then (once question a) is solved :) ). -- You are receiving this mail because: You are watching all bug changes.
