https://bugs.kde.org/show_bug.cgi?id=518221

--- Comment #5 from Mark Wielaard <[email protected]> ---
(In reply to Alexandra Hajkova from comment #4)
> Created attachment 195298 [details]
> patch

This looks really good. Quick testing also confirms it works correctly.

It should have the bug URL in the commit message, and the commit message could
be a little more expressive.

super small nitpick:
+       IRTemp srcVec = newTemp(Ity_V128);
+       modrm  = insn[3];
+       UInt   rG     = gregOfRM(modrm);
why is  modrm   = insn[3]; not lined up with the = of srcVec and rG?

Please push with (or without) fixing those nitpicks.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to