https://bugs.kde.org/show_bug.cgi?id=522907
--- Comment #6 from Alex Hirzel <[email protected]> --- A behavior that only overwrites or replaces (not removes extra fields) seems good to me. I think the meaning of the setGPSInfo name feels rather broad, as well as removeGPSInfo. Perhaps this could be deprecated in favor of setGPSCoordinates/removeGPSCoordinates or something similar so that the former's data loss behavior becomes more explicit. I don't know of an easy way to search for call sites of setGPSInfo other than those in digikam (local copy). Within digikam, there are several call sites, of which two seem most relevant: GPSItemContainer::saveChanges has a concept of "shouldWriteCoordinates" MetaEngine::setGPSInfo seems to also deal with only coordinates Looking only at these, it seems setGPSInfo/removeGPSInfo are really only expected to manipulate the coordinates. So we could also change their behavior in-place from this perspective (but perhaps there are other call sites in other projects with different expectations). -- You are receiving this mail because: You are watching all bug changes.
