https://bugs.kde.org/show_bug.cgi?id=521413
--- Comment #8 from Mark Wielaard <[email protected]> --- (In reply to mcermak from comment #7) > Created attachment 194647 [details] > proposed patch - .gitignore new test, ack. - NEWS add bug, ack. - guest_x86_defs.h define x86g_dirtyhelper_PCMPxSTRx, ack. - VEX/priv/guest_x86_toIR.c. Add OFFB_XMM8. dis_PCMPxSTRx32 adapted from amd dis_PCMPxSTRx, takes isAvx but that is never used. could be dropped to simplify code. Comment still calls the pseudo-register XMM16 in one place, but should be XMM8 for x86. The special case for dis_PCMPISTRI_3A is commented out and not implemented. I am not sure I am following that case in the amd64 code either. Could you explain? The rest of the function looks correct. As does the actual instruction detection. - VEX/pub/libvex_guest_x86.h. ack. Extend state with fake XMM8 reg. - VEX/priv/guest_x86_helpers.c. zmask_from_V128 and zmask_from_V128_wide might be put in a shared header (as static inline), but that is not really necessary. x86g_dirtyhelper_PCMPxSTRx comment says "fake XMM16 register" but that should be "fake XMM8 register". Code looks correct, it uses compute_PCMPxSTRx and compute_PCMPxSTRx_wide which are already shared in guest_generic_x87. - none/tests/x86/Makefile.am, ack. Add new testcase. - none/tests/x86/pcmpxstrx32.vgtest, prereq should test against x86-sse42 not amd64-sse42 to work on "pure" x86 32bit systems. Also it might be build on systems where configure detects it cannot So prereq should be test -e pcmpxstrx32 && ../../../tests/x86_amd64_features x86-sse42 - none/tests/x86/pcmpxstrx32.stdout.exp, ack, regenerates from native OK. - none/tests/x86/pcmpxstrx32.c looks like the correct adaption of none/tests/amd64/pcmpxstrx64.c (offsets and regnames changed). OK. -- You are receiving this mail because: You are watching all bug changes.
