https://bugs.kde.org/show_bug.cgi?id=524945

            Bug ID: 524945
           Summary: Show/Hide Terminal Panel option text doesn't update
                    correctly
    Classification: Applications
           Product: kate
      Version First 26.04.3
       Reported In:
          Platform: Other
                OS: Microsoft Windows
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: [email protected]
          Reporter: [email protected]
  Target Milestone: ---

DESCRIPTION

The "Show Terminal Panel" vs "Hide Terminal Panel" text doesn't correctly
toggle after showing/hiding terminal panel.

STEPS TO REPRODUCE
1. Open Kate, by default terminal panel is not active.
2. Select Tools > Show Terminal Panel, terminal panel opens as expected
3. Select Tools > Hide Terminal Panel, terminal panel closes as expected
4. Select Tools > option is still Hide Terminal Panel (clicking action will
open panel)

OBSERVED RESULT
Option text doesn't toggle correctly according to current terminal panel state.

EXPECTED RESULT
Option text should toggle correctly.

SOFTWARE/OS VERSIONS
Windows 10
Kate 26.04.3

ADDITIONAL INFORMATION

Taking a peek at the source code, it seems like a logical mismatch.
slotToggleVisibility is looking at the state of m_part->widget()->isVisible()
for determining whether to open or close. However, the text is being updated
using m_toolView->isHidden(). Shouldn't these two checks match?

It previously was until
https://github.com/KDE/kate/commit/d9c57d894c218dfe5e741570ea9e404549ac6732.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to