https://bugs.kde.org/show_bug.cgi?id=518221

--- Comment #8 from Mark Wielaard <[email protected]> ---
(In reply to Alexandra Hajkova from comment #7)
> Created attachment 195902 [details]
> patch
> 
>     Implement PMOVZXBD SSE4.1 for x86
>     
>     Add dis_PMOVxXBD helper to share the instruction decoding
>     between PMOVSXBD and PMOVZXBD.
>     
>     Move test_PMOVZXBD from none/tests/amd64/sse4-64.c to
>     none/tests/sse4-common.h so both amd64 and x86
>     implementations can share it.

Looks good. Nice having one helper function.
It matches the amd64 version (dis_PMOVxXBD_128), which also handles avx, which
x86 doesn't have to.
Implementation looks good.
Tests refactoring also looks correct.
Quick test shows it working locally (for both ams64 and x86).

Please push.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to