https://bugs.kde.org/show_bug.cgi?id=376773

--- Comment #1 from Jonathan Marten <j...@keelhaul.me.uk> ---
There is a suspicious use of the KNotification signals in
ReceiveFileJob::showNotification().  The signals are connected:

  KNotification::action1Activated   ->  ReceiveFileJob::slotAccept
  KNotification::action2Activated   ->  ReceiveFileJob::slotCancel
  KNotification::closed             ->  ReceiveFileJob::slotCancel

The last of these makes sense, to decline the file transfer if the notification
is closed or times out.  However, the API documentation for
KNotification::closed says:

  Emitted when the notification is closed.

  Can be closed either by the user clicking the close button,
  the timeout running out or when an action was triggered.

I haven't looked at the KNotification code for this, but from the description
it would appear that closed() signal is sent, in addition to
action1Activated(), when the "Accept" button is clicked.  This would account
for the calls to slotAccept and then slotCancel in the log.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to