https://bugs.kde.org/show_bug.cgi?id=376739
Elvis Angelaccio <elvis.angelac...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/pla
| |sma-nm/2c70ac2a6eddc9f87eac
| |7e4e3a8c68f558d7dd0b
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
Version Fixed In| |5.9.3
--- Comment #7 from Elvis Angelaccio <elvis.angelac...@kde.org> ---
Git commit 2c70ac2a6eddc9f87eac7e4e3a8c68f558d7dd0b by Elvis Angelaccio.
Committed on 21/02/2017 at 13:59.
Pushed by elvisangelaccio into branch 'Plasma/5.9'.
Don't assume initialized if there are pending dbus replies
Summary:
ConnectionEditorBase::initialize() does not count the number of pending dbus
replies, so it is currently assuming that if control reaches the end of the
function, we are not waiting for secrets and we can claim the kcm is
initialized. That is not necessarily true, as bug #376739 shows.
If we count the number of replies actually received, we can be sure that there
are no more pending replies and we can then set m_initialized to true at the
end of initialize().
FIXED-IN: 5.9.3
Test Plan:
Open Connection KCM from systemsettings5, no longer had the Apply button
enabled. Playing with the KCM still enables the Apply button if something is
changed.
Reviewers: jgrulich
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4705
M +6 -1 libs/editor/connectioneditorbase.cpp
M +1 -0 libs/editor/connectioneditorbase.h
https://commits.kde.org/plasma-nm/2c70ac2a6eddc9f87eac7e4e3a8c68f558d7dd0b
--
You are receiving this mail because:
You are watching all bug changes.
