https://bugs.kde.org/show_bug.cgi?id=503535

Don <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #2 from Don <[email protected]> ---
Hi all, I've also hit same problem. Had to workaround. 

openconnect.h (v9.21) spells the problem out: “we switched the
openconnect_get_hostname() function to return the \*IP\* address instead… So
returning just the IP address from openconnect_get_hostname() now made things
break.” and prescribes:
openconnect $CONNECT_URL --servercert $FINGERPRINT --cookie $COOKIE --resolve
$DNSNAME:$HOSTNAME

this was fixed in gnome. The fix is minor:

// vpn/openconnect/openconnectauth.cpp  (setting())
-    QString host(openconnect_get_hostname(d->vpninfo));      // IP, breaks
SNI/Host routing
+    QString host(QLatin1String(openconnect_get_dnsname(d->vpninfo)));  // real
name
...
     secrets.insert(QLatin1String(NM_OPENCONNECT_KEY_GATEWAY), gateway);
+    // pin the address we authenticated against, exactly like nm-openconnect
+    const char *ip = openconnect_get_hostname(d->vpninfo);
+    if (ip && g_strcmp0(ip, host.toUtf8().constData()))
+        secrets.insert(QLatin1String(NM_OPENCONNECT_KEY_RESOLVE),
+                       QStringLiteral("%1:%2").arg(host,
QString::fromUtf8(ip)));

// vpn/openconnect/nm-openconnect-service.h  (missing key; the NM plugin
already honours it → --resolve)
#define NM_OPENCONNECT_KEY_RESOLVE "resolve"```

----

Should I prepare a MR for this?

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to