https://bugs.kde.org/show_bug.cgi?id=525856

cwo <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
                   |ma/kdeplasma-addons/-/commi |ma/kdeplasma-addons/-/commi
                   |t/26ff6fb9449c879d03a21624a |t/c54063d7ecaf9b5d0ddec62a3
                   |e4599a93d7826fc             |80a612cbf7ba129

--- Comment #4 from cwo <[email protected]> ---
Git commit c54063d7ecaf9b5d0ddec62a380a612cbf7ba129 by Christoph Wolk.
Committed on 28/09/2026 at 12:18.
Pushed by cwo into branch 'Plasma/6.8'.

applets/comic: avoid infinite reload loop

Some comic providers might misbehave and emit more than one final
signal per request. One such case is the nichtlustig provider, which
parses not just the page, but also the downloaded image as if it was
the web page (and fails because it's a jpeg, not an html page, so is
unlikely to happen to contain the relevant link). This then breaks our
update checker, which expects each provider plugin to only emit one
signal per request, and causes it to restart the update checking
constantly redownloading the same file (and bypassing the cache, as
we're in update checking mode).

Instead, check whether the data updated signal is for the provider that
we're currently checking. If it's not, we just ignore it. This part of
the code is just for tracking updates anyway, the actual error/image
handling lives elsewhere.


(cherry picked from commit 0bf0749f80d74988ecb34fc580e0110a09ed135a)

Co-authored-by: Christoph Wolk <[email protected]>

M  +5    -0    applets/comic/checknewstrips.cpp

https://invent.kde.org/plasma/kdeplasma-addons/-/commit/c54063d7ecaf9b5d0ddec62a380a612cbf7ba129

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to