https://bugs.kde.org/show_bug.cgi?id=505558

Pavel Radzivilovsky <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
            Version|                            |6.8.1
  Fixed/Implemented|                            |
                 In|                            |
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/powerdevil/-/commit/4975
                   |                            |1e9dd287e7478f13aef2b0f8267
                   |                            |d689ab9a1
             Status|CONFIRMED                   |RESOLVED

--- Comment #7 from Pavel Radzivilovsky <[email protected]> ---
Git commit 49751e9dd287e7478f13aef2b0f8267d689ab9a1 by Pavel Radzivilovsky.
Committed on 14/10/2026 at 08:18.
Pushed by ngraham into branch 'master'.

Show the brightness OSD when a brightness key is pressed at min/max

Pressing the brightness-up key at 100% (or brightness-down at the
minimum) currently gives no visual feedback at all. Users read that as
"the key press was not registered" rather than "already at maximum".
The volume OSD shows up in the same situation, and so did the brightness
OSD until Plasma 6.1: commit 4b8ae4d7 fixed exactly this for 5.14
(BUG 387284).

The brightness step refactor in db60877ee (6.2) moved the OSD call into
the brightnessChanged signal handler, which only fires when the tracked
brightness value actually changes. adjustBrightnessStep() and
adjustBrightnessRatio() additionally return early when no display has
room to move, so the ShowIndicator hint was silently dropped.

Add a brightnessIndicatorRequested signal that the controller emits in
those no-op cases when the ShowIndicator hint is set, and let
ScreenBrightnessAgent show the OSD with the current brightness for it.
The D-Bus BrightnessChanged signal is intentionally not emitted, since
nothing changed.
FIXED-IN: 6.8.1

M  +18   -0    daemon/controllers/screenbrightnesscontroller.cpp
M  +8    -0    daemon/controllers/screenbrightnesscontroller.h
M  +13   -7    daemon/powerdevilscreenbrightnessagent.cpp
M  +1    -0    daemon/powerdevilscreenbrightnessagent.h

https://invent.kde.org/plasma/powerdevil/-/commit/49751e9dd287e7478f13aef2b0f8267d689ab9a1

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to