https://bugs.kde.org/show_bug.cgi?id=527043

Jasem Mutlaq <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/educ
                   |                            |ation/kstars/-/commit/862ed
                   |                            |9de262ca1b65fac103491425131
                   |                            |854dbd8f
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Jasem Mutlaq <[email protected]> ---
Git commit 862ed9de262ca1b65fac103491425131854dbd8f by Jasem Mutlaq.
Committed on 16/10/2026 at 06:28.
Pushed by mutlaqja into branch 'master'.

Capture: turn off the light box when capturing ends

The calibration light was never turned off at the end of a capture
sequence: stopCapturing() only did so if lightBoxLightEnabled() was set,
but nothing ever set it. A standalone flat sequence, or flats at the end
of the queue, left the light on indefinitely.

Remember when Capture turns the light on, and turn it off when capturing
completes, is aborted or is stopped. Leave it on between consecutive jobs
of a sequence and while capturing is suspended or paused, and leave a
light alone that Capture did not turn on.

Turning the light off between jobs is not only needless wear: the next
job synced the light state from the device before the driver had
answered, read the outdated "on", and captured its flats with the light
off. The light box now reports busy until the driver confirms a light
command, so a job started right after an abort waits for the light.

Add UI tests with the light panel simulator for consecutive flat jobs,
flats followed by lights, abort, stop, suspend, pause, restart right
after an abort, and a light turned on outside of Capture.

Based on the analysis in MR !1843.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

M  +247  -0    Tests/kstars_ui/test_ekos_capture_workflow.cpp
M  +28   -0    Tests/kstars_ui/test_ekos_capture_workflow.h
M  +9    -4    kstars/ekos/capture/cameraprocess.cpp
M  +3    -1    kstars/ekos/capture/cameraprocess.h
M  +4    -0    kstars/ekos/capture/camerastate.h
M  +2    -0    kstars/ekos/capture/sequencejobstate.cpp
M  +3    -0    kstars/indi/indilightbox.cpp

https://invent.kde.org/education/kstars/-/commit/862ed9de262ca1b65fac103491425131854dbd8f

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to