https://bugs.kde.org/show_bug.cgi?id=526073

cwo <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
                   |ma/plasma-desktop/-/commit/ |ma/plasma-desktop/-/commit/
                   |ebfd56d594548ac1855481015ab |8bd048fb6d343021c9926d37bfe
                   |15e3455dc4a0a               |8c6d85c08e900

--- Comment #5 from cwo <[email protected]> ---
Git commit 8bd048fb6d343021c9926d37bfe8c6d85c08e900 by Christoph Wolk.
Committed on 29/10/2026 at 18:22.
Pushed by cwo into branch 'Plasma/6.8'.

containments/desktop: don't reset press position onModelReset

FolderView tracks the pointer position on press, and uses that
information on pointer move to start a drag or rubberband. However,
when something resets the model (such as when a lot of files are deleted
and each deletion resets the model), this information is reset. For the
most part, this means that you can't rubberband while the deletions
happen (you press, the press is reset, you move the mouse and nothing
happens) which isn't great but also not too bad. However, if you manage
to time it just right that the click and move happens fully within the
short period between resets, you'll start the rubberband, then the reset
changes the active rubberband to start at -1, -1 instead of the position
you actually clicked.

This is quite weird, and it's also not great that rubberbanding while
something is being deleted works sometimes and not at other times. The
reason for resetting all pressed state seems to only apply to the
pressed item, not the position itself. So we can just reset that
individually and skip the rest.

However, during stress testing I've been able to get it in a broken
state while repeatedly deleting and undeleting files and doing
rubberbands, where the rubberband remains active even when the mouse
button is no longer pressed, and can't be canceled unless the user
actually selects something with the rubberband. I don't have clear
reproduction steps, but it probably makes sense to just generally cancel
the rubberband if the button is no longer pressed - this way we should
shut down this whole class of errors (this is not the first time I've
seen something like this happen).
FIXED-IN: 6.9.0


(cherry picked from commit a1e570a41db4b772b09a7c4c99c4bb2765295c7e)

Co-authored-by: Christoph Wolk <[email protected]>

M  +6    -1    containments/desktop/package/contents/ui/FolderView.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/8bd048fb6d343021c9926d37bfe8c6d85c08e900

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to