https://bugs.kde.org/show_bug.cgi?id=363224

--- Comment #59 from Lubos Lunak <l.lu...@kde.org> ---
Created attachment 104621
  --> https://bugs.kde.org/attachment.cgi?id=104621&action=edit
proposed fix

As seen in the Valgrind log, this is basically bug #347490. The supposed fix
30e6ae34d7 for that one only moved the problem, so instead of delayed slots
crashing because of deleted Client objects, it now crashes because of deleted
EffectWindow objects.

This patch reverts that commit and also the delayed signals, based on the
following:
- 30e6ae34d7 only papers over the problem
- the commit introducing the delaying of the signal doesn't explain it (*sigh*)
and so the only reasoning for it is a comment in #347490 with a supposition
about it, and I cannot see any glitches with this patch attached (although
admitedly I didn't try too hard, given that I don't know what to look for)
- the logic of delaying of just this one signal seems wrong to me, if it would
be needed, surely other signals would need similar delaying as well
- if it turns out any delaying is actually necessary, it should be done
properly where needed (such as triggering a delayed repaint in the appropriate
place)

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to