https://bugs.kde.org/show_bug.cgi?id=377829
Bug ID: 377829
Summary: [patch?] dvdwizard menu edit chapter label names
Product: kdenlive
Version: git-master
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity: wishlist
Priority: NOR
Component: User Interface
Assignee: j...@kdenlive.org
Reporter: michael.v...@gmail.com
Target Milestone: ---
Created attachment 104651
--> https://bugs.kde.org/attachment.cgi?id=104651&action=edit
Possible patch
Hi,
attached is a patch that is mostly meant as a RFC. I'm happy to refine if the
direction looks ok but I don't want to waste time if the direction is
undesirable so I post it for even if its not fully ready.
My goal is to make the dvdwizard a little bit nicer, i.e. so that when you have
labeled "guides" and export them as dvd metadata then the chapter names are
available inside the menu editor in the "target" combo box to make it easy to
create buttons that jump to the right guide.
Originally I started with this in a relatively simple manner, but because the
chapter times are all passed strings joined with "," adding titles became a bit
cumbersome. This is why I added the new Chapter and VobChapters classes. If
that seems overkill I'm happy to rethink things. Also, if a bugreport is the
wrong channel to discuss this, I'm happy to post the patch on the mailinglist
or any other place.
Attached the patch, it works for me but I have not tested all combination (the
part around DvdWizardVob::updateChapters probably needs some extra work). It
also probably does a bit of unneeded pass-by-value (but maybe not, I need to
figure out how the user-data is attached etc).
Thanks for reading!
Michael
--
You are receiving this mail because:
You are watching all bug changes.
