https://bugs.kde.org/show_bug.cgi?id=378538

Dmitry Kazakov <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
                   |ta/3ce218ca6674deeaa0539fe7 |ta/89641bfc428c268ae3fe42a0
                   |b96d19577dc99641            |f4dd350b111ebc72

--- Comment #3 from Dmitry Kazakov <[email protected]> ---
Git commit 89641bfc428c268ae3fe42a0f4dd350b111ebc72 by Dmitry Kazakov.
Committed on 01/05/2017 at 08:17.
Pushed by dkazakov into branch 'krita/3.1'.

Don't let the user close the document while saving is in progress

Ideally, we should postpone closing till the saving is finished,
but it is impossible to do right now, because doc->setModified()
is called outside the saving lock held. Later, when we refactor
the saving code and the modified state will be cleared under
the lock, we can easily use KisSignalCompressor to close the
document.

The crash itself happened because the hack in KisPart::removeView()
just skipped the deinitialization of the view and the input manager
was still connected to the canvas that was destroyed.

# Conflicts:
#       libs/ui/KisDocument.cpp

M  +6    -0    libs/ui/KisDocument.cpp
M  +7    -0    libs/ui/KisDocument.h
M  +0    -7    libs/ui/KisMainWindow.cpp
M  +1    -13   libs/ui/KisPart.cpp
M  +0    -2    libs/ui/KisPart.h
M  +7    -0    libs/ui/KisView.cpp

https://commits.kde.org/krita/89641bfc428c268ae3fe42a0f4dd350b111ebc72

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to