https://bugs.kde.org/show_bug.cgi?id=380452

Hugo Pereira Da Costa <hugo.pereira.da.co...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/oxy
                   |                            |gen/cbc5fdbd4654118c6ec3777
                   |                            |6b060420e520c216b

--- Comment #4 from Hugo Pereira Da Costa <hugo.pereira.da.co...@gmail.com> ---
Git commit 8a4e31bc99ed5ada95f2ebf1eb8151c52a1d5420 by Hugo Pereira Da Costa.
Committed on 02/06/2017 at 08:08.
Pushed by hpereiradacosta into branch 'master'.

Q_DECL_OVERRIDE -> override
Rationale is that oxygen decoration depends on libkdecoration, which uses
override directly already.

M  +3    -3    kdecoration/config/oxygenanimationconfigwidget.h
M  +1    -1    kdecoration/config/oxygendetectwidget.h
M  +4    -4    kdecoration/config/oxygenexceptionmodel.h
M  +1    -1    kdecoration/config/oxygenitemmodel.h
M  +1    -1    kdecoration/oxygenbutton.h
M  +1    -1    kdecoration/oxygendecohelper.h

https://commits.kde.org/oxygen/8a4e31bc99ed5ada95f2ebf1eb8151c52a1d5420

--- Comment #5 from Hugo Pereira Da Costa <hugo.pereira.da.co...@gmail.com> ---
Git commit cbc5fdbd4654118c6ec37776b060420e520c216b by Hugo Pereira Da Costa.
Committed on 02/06/2017 at 08:12.
Pushed by hpereiradacosta into branch 'master'.

Partially revert "Use Q_DECL_OVERRIDE"

The style code can be built with Qt4/kdelibs4 as well, and there is no
Q_DECL_OVERRIDE in that case.

This partially reverts commit 1bf982f43470c9441287f3fd6a8a3dee834e1483

M  +2    -2    kstyle/animations/oxygenbusyindicatorengine.h
M  +1    -1    kstyle/animations/oxygendockseparatordata.h
M  +3    -3    kstyle/animations/oxygendockseparatorengine.h
M  +1    -1    kstyle/animations/oxygenenabledata.h
M  +1    -1    kstyle/animations/oxygengenericdata.h
M  +2    -2    kstyle/animations/oxygenheaderviewdata.h
M  +3    -3    kstyle/animations/oxygenheaderviewengine.h
M  +1    -1    kstyle/animations/oxygenmdiwindowdata.h
M  +3    -3    kstyle/animations/oxygenmdiwindowengine.h
M  +5    -5    kstyle/animations/oxygenmenubardata.h
M  +21   -21   kstyle/animations/oxygenmenubarengine.h
M  +7    -7    kstyle/animations/oxygenmenudata.h
M  +21   -21   kstyle/animations/oxygenmenuengine.h
M  +1    -1    kstyle/animations/oxygenprogressbardata.h
M  +3    -3    kstyle/animations/oxygenprogressbarengine.h
M  +2    -2    kstyle/animations/oxygenscrollbardata.h
M  +3    -3    kstyle/animations/oxygenscrollbarengine.h
M  +1    -1    kstyle/animations/oxygenspinboxdata.h
M  +3    -3    kstyle/animations/oxygenspinboxengine.h
M  +3    -3    kstyle/animations/oxygensplitterengine.h
M  +1    -1    kstyle/animations/oxygentabbardata.h
M  +3    -3    kstyle/animations/oxygentabbarengine.h
M  +3    -3    kstyle/animations/oxygentoolbardata.h
M  +4    -4    kstyle/animations/oxygentoolbarengine.h
M  +3    -3    kstyle/animations/oxygentoolboxengine.h
M  +3    -3    kstyle/animations/oxygenwidgetstateengine.h
M  +3    -3    kstyle/config/oxygenanimationconfigwidget.h
M  +2    -2    kstyle/config/oxygenfollowmouseanimationconfigitem.h
M  +1    -1    kstyle/config/oxygenstyleconfig.h
M  +1    -1    kstyle/debug/oxygenwidgetexplorer.h
M  +2    -2    kstyle/demo/oxygendemodialog.h
M  +1    -1    kstyle/demo/oxygensimulator.h
M  +1    -1    kstyle/oxygenaddeventfilter.h
M  +2    -2    kstyle/oxygenblurhelper.h
M  +8    -8    kstyle/oxygenframeshadow.h
M  +2    -2    kstyle/oxygenmdiwindowshadow.h
M  +1    -1    kstyle/oxygenmnemonics.h
M  +1    -1    kstyle/oxygenshadowhelper.h
M  +2    -2    kstyle/oxygensplitterproxy.h
M  +3    -3    kstyle/oxygenstyle.cpp
M  +14   -14   kstyle/oxygenstyle.h
M  +4    -4    kstyle/oxygenstylehelper.h
M  +1    -1    kstyle/oxygenstyleplugin.h
M  +1    -1    kstyle/oxygenwindowmanager.cpp
M  +2    -2    kstyle/oxygenwindowmanager.h
M  +4    -4    kstyle/transitions/oxygencomboboxdata.h
M  +3    -3    kstyle/transitions/oxygencomboboxengine.h
M  +4    -4    kstyle/transitions/oxygenlabeldata.h
M  +3    -3    kstyle/transitions/oxygenlabelengine.h
M  +4    -4    kstyle/transitions/oxygenlineeditdata.h
M  +3    -3    kstyle/transitions/oxygenlineeditengine.h
M  +2    -2    kstyle/transitions/oxygenstackedwidgetdata.h
M  +3    -3    kstyle/transitions/oxygenstackedwidgetengine.h
M  +2    -2    kstyle/transitions/oxygentransitionwidget.h
M  +2    -2    liboxygen/oxygengenericanimationconfigitem.h
M  +26   -26   liboxygen/oxygenitemmodel.h
M  +4    -4    liboxygen/oxygenlistmodel.h

https://commits.kde.org/oxygen/cbc5fdbd4654118c6ec37776b060420e520c216b

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to