https://bugs.kde.org/show_bug.cgi?id=373005
Elvis Angelaccio <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Version Fixed In| |17.04.3 Latest Commit| |https://commits.kde.org/dol | |phin/c85ca114553c198af79eed | |acdb6b40ac4cab20e0 Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #9 from Elvis Angelaccio <[email protected]> --- Git commit c85ca114553c198af79eedacdb6b40ac4cab20e0 by Elvis Angelaccio. Committed on 11/06/2017 at 17:11. Pushed by elvisangelaccio into branch 'Applications/17.04'. Ignore drops-onto-items from invalid places items If the QMimeData object created by PlacesItemModel doesn't have any url set (e.g. when dragging unmounted devices), it is detected by the resulting DropJob as "drop raw data" because the mimeData has one format set (the internalMimeType() used for dragging between places items). This results in a crash because the DropJob schedules a PasteJob, but in the meantime the QDrag from Dolphin ends and deletes the mimeData object that was passed to the paste job. The fix is to prevent the DropJob in the first place. We can introduce a new internal mimetype that we use to blacklist drops-onto-items (while still allowing drops-between-items). This way PlacesItemModel can set the blacklist flag if the mimeData is being created without urls. FIXED-IN: 17.04.3 Test Plan: Drag and drop an unmounted device to another place item or the DolphinView, doesn't crash anymore. Dropping the unmounted device between two places item still works. Differential Revision: https://phabricator.kde.org/D5535 M +1 -1 src/kitemviews/kitemlistcontroller.cpp M +5 -0 src/kitemviews/kitemmodelbase.cpp M +10 -0 src/kitemviews/kitemmodelbase.h M +3 -0 src/panels/places/placesitemmodel.cpp https://commits.kde.org/dolphin/c85ca114553c198af79eedacdb6b40ac4cab20e0 -- You are receiving this mail because: You are watching all bug changes.
