https://bugs.kde.org/show_bug.cgi?id=374933

Harald Sitter <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kwi
                   |                            |dgetsaddons/ca40063c4e4936d
                   |                            |02c8a9cec0c45ecb643ffd5be

--- Comment #15 from Harald Sitter <[email protected]> ---
Git commit ca40063c4e4936d02c8a9cec0c45ecb643ffd5be by Harald Sitter.
Committed on 18/07/2017 at 09:32.
Pushed by sitter into branch 'master'.

do not crash qaccessible by causing a resize in a resize event

Summary:
When enabling accessibility qaccessible will automatically add a11y support
constructs to core qt types such as qtableview.
Unfortunately for qtableview specifically a change of the layout/size will
discard the accessible objects modeling the individual cells in our table.
Combined with the way we control layout through the model [I am not sure
why we do this to begin with] this can result in call chains where
qaccessible triggers a resizeEvent which we'll handle by rejiggering
our model to get a new layout, resulting in qaccessible deleting the
object which originally caused the event and ending in a segfault.

To prevent this problem we delay the rejiggering of our model by running
the call through the eventloop (i.e. the resize is executed once the stack
unwinds again to the event loop).

CHANGELOG: Fixed a crash when searching with accessibility support enabled

Also see https://bugreports.qt.io/browse/QTBUG-58153

Test Plan: spent a good while searching and copy pasting and all that fun
stuff. no more crashing.

Reviewers: gladhorn, cfeck

Reviewed By: cfeck

Subscribers: cfeck, anthonyfieroni, #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D6624

M  +17   -1    src/kcharselect.cpp

https://commits.kde.org/kwidgetsaddons/ca40063c4e4936d02c8a9cec0c45ecb643ffd5be

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to