Eike Hein <> changed:

           What    |Removed                     |Added
         Resolution|---                         |FIXED
      Latest Commit|                            |
                   |                            |sma-workspace/75b7f5c2fa63b
                   |                            |c1ef13ac6fb5f82c7d52bfabd6c
             Status|REOPENED                    |RESOLVED

--- Comment #10 from Eike Hein <> ---
Git commit 75b7f5c2fa63bc1ef13ac6fb5f82c7d52bfabd6c by Eike Hein.
Committed on 07/08/2017 at 10:24.
Pushed by hein into branch 'master'.

Keep fallback icon updated

Windows we can't find an app icon for using the normal means
get the icon used by the windowing system in the Task Manager.
This fallback icon was then not updated when changed on the
window, only occasionally as a side-effect of cache evictions
and model data requests.

This patch notes which windows hit the fallback path, and for
those windows evicts the cache when the icon changes on the
window, causing it to be re-retrieved from the windowing system
as views respond to the dataChanged signal for the decoration

Evicting the entire cache is a little bit costly, but:
- This is a fallback codepath.
- Apps conventionally update title and icon in one go, meaning
  the cache is often already getting evicted anyway.
- Icons don't change that often.

Reviewers: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision:

M  +10   -2    libtaskmanager/xwindowtasksmodel.cpp

You are receiving this mail because:
You are watching all bug changes.

Reply via email to