--- Comment #85 from David Faure <> ---
Git commit 32526718eae99ccb594360627586eebdf793372b by David Faure.
Committed on 11/08/2017 at 06:26.
Pushed by dfaure into branch 'master'.

KKeyServer: fix handling of KeypadModifier.

This required adding a new method symXModXToKeyQt since
symXToKeyQt (without modifier as input) has no way to find out
whether to use XK_KP_1 or XK_1. For this reason symXToKeyQt is now

Includes a unittest for keyQtToSymX, keyQtToModX and symXModXToKeyQt.

Test Plan:
After porting kglobalaccel to KKeyServer::xcbKeyPressEventToQt,
the following global shortcuts were successfully tested:
Ctrl+1, Ctrl+Num+1, Ctrl+Num+/, Ctrl+F1, Ctrl+& (implicit shift)

Reviewers: graesslin

Subscribers: graesslin, #frameworks

Tags: #frameworks

Differential Revision:

M  +1    -0    autotests/CMakeLists.txt
A  +79   -0    autotests/kkeyserver_x11_unittest.cpp     [License: LGPL
M  +96   -52   src/platforms/xcb/kkeyserver.cpp
M  +13   -1    src/platforms/xcb/kkeyserver_x11.h

You are receiving this mail because:
You are watching all bug changes.

Reply via email to