https://bugs.kde.org/show_bug.cgi?id=383843
Kevin Funk <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED --- Comment #1 from Kevin Funk <[email protected]> --- This looks really bad...: 528│ void SlaveBase::processedSize(KIO::filesize_t _bytes) 529│ { 530├> bool emitSignal = false; 531│ 532│ QDateTime now = QDateTime::currentDateTime(); 533│ 534│ if (_bytes == d->totalSize) { 535│ emitSignal = true; 536│ } else { 537│ if (d->lastTimeout.isValid()) { 538│ emitSignal = d->lastTimeout.msecsTo(now); // emit size 10 times a second 539│ } else { 540│ emitSignal = true; 541│ } 542│ } 538│ emitSignal = d->lastTimeout.msecsTo(now); // emit size 10 times a second ^ This expression is totally wrong, isn't it? It doesn't do what the comment says. It will evaluate to true if there's just a millisecond time difference => signal will be emitted every ms? -- You are receiving this mail because: You are watching all bug changes.
