https://bugs.kde.org/show_bug.cgi?id=384633
Ivo Raisr <iv...@ivosh.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |iv...@ivosh.net
--- Comment #2 from Ivo Raisr <iv...@ivosh.net> ---
Thank you for the patch, Julian.
I will implement VG_(get_user_milliseconds)() for Solaris, that's not a
problem.
However I wonder why allowed values for --progress-interval are only 1..3600?
Why not 0, the default?
Please also do something with comments around next_report_due_at, they look
really scary. This is not the first static variable we have in Valgrind...
What happens if a Valgrind'ed process with --progress-interval > 0 is suspended
for several minutes? Is the logic in maybe_progress_report() able to cope
with this?
And the last nit - please use %u for "#thr" formatting instead of "%d".
nThreads is UInt.
--
You are receiving this mail because:
You are watching all bug changes.
