https://bugs.kde.org/show_bug.cgi?id=364884
Nate Graham <pointedst...@zoho.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/bal
| |oo/db30f89f1c88fd3cf52e9df9
| |5c8411be69275a71
Resolution|--- |FIXED
--- Comment #3 from Nate Graham <pointedst...@zoho.com> ---
Git commit db30f89f1c88fd3cf52e9df95c8411be69275a71 by Nathaniel Graham.
Committed on 23/09/2017 at 13:58.
Pushed by ngraham into branch 'master'.
Only match real MIME types, not e.g. "raw CD image"
Summary:
Only match real MIME types when doing string matching to prevent pulling in
unrelated files whose types match the string.
This prevents weird situations such as ISO files (which show up as "raw CD
image") appearing in image searches.
Test Plan:
- Confirmed at www.mime-type.net/ that all audio, video, and image MIME types
have the key word before the slash (e.g. "image/")
- Booted a clean KDE Neon VM and added an ISO and a bunch of pictures of
various types
- Confirmed the problem: `baloosearch -t image iso` shows ISO files
- Patched and rebuilt Baloo
- Forced a re-index operation (balooctl disable; rm
~/.local/share/baloo/index*; balooctl enable)
- Did a new image search (`baloosearch -t image iso`) and confirmed that the
ISO does not show up
- Confirmed that other images still show up
Reviewers: #frameworks, nicolasfella, dfaure, kossebau, vhanda
Reviewed By: dfaure
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D7948
M +5 -5 src/file/basicindexingjob.cpp
https://commits.kde.org/baloo/db30f89f1c88fd3cf52e9df95c8411be69275a71
--
You are receiving this mail because:
You are watching all bug changes.
