https://bugs.kde.org/show_bug.cgi?id=385551
Bug ID: 385551
Summary: kphotoalbum-5.2/ThumbnailView/ThumbnailDND.cpp: broken
if statement ?
Product: kphotoalbum
Version: unspecified
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: Thumbnail Viewer
Assignee: kpab...@willden.org
Reporter: dcb...@hotmail.com
Target Milestone: ---
[/home/dcb/rpmbuild/BUILD/kphotoalbum-5.2/ThumbnailView/ThumbnailDND.cpp:48] ->
[/home/dcb/rpmbuild/BUILD/kphotoalbum-5.2/ThumbnailView/ThumbnailDND.cpp:62]:
(warning) Identical condition 'fileName.isNull()', second condition is always
false
Source code is
if (fileName.isNull())
{
// cursor not in drop zone (e.g. empty space right/below of the
thumbnails)
return;
}
then later:
if ( fileName.isNull() ) {
// We're dragging behind the last item
model()->setRightDropItem(model()->imageAt( model()->imageCount() -
1));
} else {
The second if can never be true.
--
You are receiving this mail because:
You are watching all bug changes.
