https://bugs.kde.org/show_bug.cgi?id=385864

Boudewijn Rempt <b...@valdyas.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kri
                   |                            |ta/a0d408f601d04e7e35e0d6fe
                   |                            |8076da48661549bb
         Resolution|---                         |FIXED

--- Comment #4 from Boudewijn Rempt <b...@valdyas.org> ---
Git commit a0d408f601d04e7e35e0d6fe8076da48661549bb by Boudewijn Rempt.
Committed on 09/11/2017 at 16:01.
Pushed by rempt into branch 'krita/3.3'.

Update the color selector dialog on showing it

If the fg or bg color hasn't been set at least once, the color
selector dialog would use the dummy internal KoColor and its
colorspace, which is rgb16. Then, on changing the color using
the spinboxes, a the current colorspace would change if the
document wasn't rgb16; the spinbox would be deleted and Krita
would crash.

This change initializes the dialog to the correct colorspace on
showing it, and moves the deletion of the spinboxes to the event
queue, using deleteLater.
Related: bug 386066

M  +6    -0    libs/ui/dialogs/kis_dlg_internal_color_selector.cpp
M  +6    -0    libs/ui/dialogs/kis_dlg_internal_color_selector.h
M  +7    -4    libs/ui/widgets/KoDualColorButton.cpp
M  +32   -18   libs/ui/widgets/kis_spinbox_color_selector.cpp

https://commits.kde.org/krita/a0d408f601d04e7e35e0d6fe8076da48661549bb

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to