https://bugs.kde.org/show_bug.cgi?id=387824
Henrik Fehlauer <rk...@lab12.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |CONFIRMED
CC| |rk...@lab12.net
--- Comment #1 from Henrik Fehlauer <rk...@lab12.net> ---
Already noticed it working locally but not on the CI too, but didn't have time
to look into it yet. Having a bug increased priority, though ;)
Thanks for pointing out the connection to KF 5.41. Some digging and bisecting
shows this is caused by 7eb6333bdb48 in KIO ("Added baloo urls into places
model"), i.e. https://phabricator.kde.org/D8332.
Besides the test, this results in new entries in the Places tab on the Start
Page:
- 4 entries for "Recently Saved" (which seem sensible)
- 4 entries for "Search For" (where Images and Videos make sense, but Documents
and Audio Files not so much – will D9332 help with this?)
Unfortunately, besides showing those entries, Gwenview stumbles a bit when
accessing the virtual folders:
- Error messages when tree-expanding those from the sidebar.
- Access via Places panel works, but not via folders sidebar.
- ASSERT: "subjobs().isEmpty()" and coredump when quickly switching back and
forth between search results and Start Page.
New usability issues, too:
- Need to scroll to access "Devices" in Places panel (viewing images on
external devices is an important feature). Perhaps make the icon size
configurable and the default size as small as in Dolphin?
- 8 more entries in the folders sidebar, making it too much for efficient
visual orientation. Either group all timeline related entries or replicate the
entire grouping from Places panel.
- Recent Folders tab on the Start Page shows long and unreadable baloosearch:/
URLs with percent encoding.
To make things worse, simply reverting to 5.40 does not work, because the
entries are now saved in .local/share/user-places.xbel permanently.
In general Gwenview should not show broken functionality, so one of the
following things need to be done (haven't looked at the code yet, not sure
whether this is simple or not):
- Block those entries completely and also handle users who used 5.41 before
Gwenview could ship such a fix.
- Fix Gwenview to handle these entries properly and only show those that make
sense. ← Preferred solution.
- (I guess the patch in KIO itself is fine, although a bit risky wrt.
expectations for the apps.)
Once that's done, we'll know the magic number to be able to fix the failing
test properly. However, it is currently unclear who would be willing to work on
those items. I'll be availabe to review and test, at least.
--
You are receiving this mail because:
You are watching all bug changes.
