https://bugs.kde.org/show_bug.cgi?id=387824

Henrik Fehlauer <rk...@lab12.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/gwe
                   |                            |nview/e8d799c9b522af299f721
                   |                            |dbbfcc650526ba78940
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #10 from Henrik Fehlauer <rk...@lab12.net> ---
Git commit e8d799c9b522af299f721dbbfcc650526ba78940 by Henrik Fehlauer.
Committed on 07/01/2018 at 23:47.
Pushed by rkflx into branch 'Applications/17.12'.

Fix failing PlaceTreeModelTest autotest

Since Frameworks 5.41, `PlaceTreeModelTest` would fail. Bisecting shows
this has been caused by 7eb6333bdb48 in KIO ("Added baloo urls into
places model"), where the model now returns 4 additional entries for
"Recently Saved" and another 4 entries for "Search For".

While the fix is trivially done by changing the number of expected
items, in a way the test functioned as a canary for problems deeper in
the code. In particular it uncovered problems when accessing the newly
added virtual folders as well as various usability issues. Some of those
are fixed already (50e6fa3ffc49 and 86d754546bd1), but there is still
some work left to do.

Test Plan: `placetreemodeltest` does not fail with KF 5.41 anymore,
still works with KF 5.40.

M  +6    -0    tests/auto/placetreemodeltest.cpp

https://commits.kde.org/gwenview/e8d799c9b522af299f721dbbfcc650526ba78940

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to