https://bugs.kde.org/show_bug.cgi?id=348267

Dmitry Kazakov <dimul...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/kri
                   |                            |ta/cc19c756f1be1d078ea50369
                   |                            |de0bbbd6fb61698c
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #3 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit cc19c756f1be1d078ea50369de0bbbd6fb61698c by Dmitry Kazakov.
Committed on 10/01/2018 at 12:42.
Pushed by dkazakov into branch 'master'.

2nd try of fixing color fluctuations in colorsmudge-dulling brushes

Now the colorsmudge brush does all the blending in the high bit-depth
colorspace. The patch introduces a special wrapper
(KisPrecisePaintDeviceWrapper) that ensures a proper color space is used
when needed. See the apidox in KisPrecisePaintDeviceWrapper.h.

NOTE: this patch fixes **both** dulling and smearing modes!

Test Plan:
Needs to be tested:
1) Colorsmudge brushes in Dulling mode with Color Rate option enabled
2) Smudge Radius enabled or disabled: both should work correctly
3) Opacity option should work correctly
4) Overlay mode?

Reviewers: #krita
Differential Revision: https://phabricator.kde.org/D9686

M  +1    -0    libs/image/CMakeLists.txt
A  +165  -0    libs/image/KisPrecisePaintDeviceWrapper.cpp     [License: GPL
(v2+)]
A  +141  -0    libs/image/KisPrecisePaintDeviceWrapper.h     [License: GPL
(v2+)]
M  +1    -1    libs/image/kis_paint_device.cc
M  +47   -0    libs/image/kis_painter.cc
M  +15   -2    libs/image/kis_painter.h
M  +117  -0    libs/pigment/KoColor.cpp
M  +45   -1    libs/pigment/KoColor.h
M  +69   -32   plugins/paintops/colorsmudge/kis_colorsmudgeop.cpp
M  +10   -3    plugins/paintops/colorsmudge/kis_colorsmudgeop.h
M  +20   -11   plugins/paintops/colorsmudge/kis_smudge_radius_option.cpp
M  +3    -1    plugins/paintops/colorsmudge/kis_smudge_radius_option.h

https://commits.kde.org/krita/cc19c756f1be1d078ea50369de0bbbd6fb61698c

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to