https://bugs.kde.org/show_bug.cgi?id=376848
Eike Hein <h...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/pla
| |sma-desktop/db42961ad4d8c87
| |877e549ce63f81b9f2bf7b0b3
Resolution|--- |FIXED
--- Comment #14 from Eike Hein <h...@kde.org> ---
Git commit db42961ad4d8c87877e549ce63f81b9f2bf7b0b3 by Eike Hein.
Committed on 05/02/2018 at 15:08.
Pushed by hein into branch 'Plasma/5.12'.
Improve preview thumbnail quality
Summary:
This patch does two things:
* Instead of giving the KAbstractViewAdapter the actual icon size,
we overprovision by giving it the size times two. This is because
while we're deriving the grid view cell size from the icon size
setting, it's not the actual size the thumbnails will be displayed
at. Our IconItem is sized to almost fill the cell, and for image
sources with non-square aspect ratios IconItem doesn't scale to
the next icon size.
* We set IconItem to do smooth scaling.
While this results in lovely visual fidelity, I the performance
impact is a concern. We're requesting twice as large thumbnails
now, and we're doing more scaling work. However, thumbnail
generation is async and doesn't slow down listing. There's also
the possibility IconItem::smooth could have general performance
impact unless things are smart enough not to scale when not
necessary, which is hopefully the case.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10223
M +2 -0 containments/desktop/package/contents/ui/FolderItemDelegate.qml
M +1 -1 containments/desktop/package/contents/ui/FolderView.qml
M +3 -0 containments/desktop/plugins/folder/foldermodel.cpp
https://commits.kde.org/plasma-desktop/db42961ad4d8c87877e549ce63f81b9f2bf7b0b3
--
You are receiving this mail because:
You are watching all bug changes.
